-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[dagster-airlift] Fix materialization reporting order for tasks #23326
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Consider |
421e541
to
b853b76
Compare
eec0f12
to
6a7ab7b
Compare
b853b76
to
b7f87ae
Compare
examples/experimental/dagster-airlift/dagster_airlift/airflow_utils.py
Outdated
Show resolved
Hide resolved
b7f87ae
to
259d879
Compare
259d879
to
f3527fb
Compare
Deploy preview for dagit-storybook ready! ✅ Preview Built with commit 259d879. |
Deploy preview for dagster-docs ready! Preview available at https://dagster-docs-3iias1ctj-elementl.vercel.app Direct link to changed pages: |
Deploy preview for dagit-core-storybook ready! ✅ Preview Built with commit 259d879. |
@@ -217,9 +218,12 @@ def airflow_dag_sensor(context: SensorEvaluationContext) -> SensorResult: | |||
"Link to Run": MarkdownMetadataValue( | |||
f"[View Run]({airflow_webserver_url}/dags/{dag_id}/grid?dag_run_id={dag_run['dag_run_id']}&tab=details)" | |||
), | |||
"Creation Timestamp": TimestampMetadataValue( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider "Event Creation Timestamp"
Fixes the materialization reporting order for asset keys mapped from airflow tasks to instead be topological.
Added a very basic test where a dependency between two tasks should always yield the downstream task being added after the upstream.